fix(v0.53.1): restore execute.ts mutation-count threading (squash-merge drop)#269
Merged
Merged
Conversation
PR #268's squash merge dropped the execute.ts changes that wire domMutationCount from MUTATION_OBSERVER_STOP_SCRIPT through to PostState. types.ts (field declaration) and state-change.ts (classifier check) both landed correctly, but without execute.ts setting the field the classifier always sees undefined and falls through to legacy behavior. Spoonworks v0.53 validation (run xkyzfn64ao7w5yia4891my4p) confirmed: postState had mutationObserverWindowMs=137 (observer ran) but no domMutationCount field → missing_state_change FP persisted at 1/5 clusters. This commit re-applies the mutPayload extraction + childList mutation count + PostState assignment. No new tests needed (state-change.test.ts already covers the classifier path).
|
✅ BugHunter Calibration | | 2026-05-16 Overall: tp=0 fp=0 fn=0 precision=1 recall=1 f1=0
|
cunninghambe
added a commit
that referenced
this pull request
May 16, 2026
Spoonworks v0.53.1 validation (run si4uxdehzj5v6od6027pkt3o) emitted 4 clusters, all real `vulnerable_dependency_high`. The missing_state_change FP that lingered in v0.52 cleared after PR #269 restored the execute.ts mutation-count threading dropped by PR #268's squash merge. Honest framing: includes the camofox cache failure caveat (3047/3338 tests completed). The 4 real-bug clusters were captured before the env issue triggered `max_infra_failures`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #268's squash merge dropped the execute.ts changes that wire `domMutationCount` from `MUTATION_OBSERVER_STOP_SCRIPT` through to `PostState`. `types.ts` (field declaration) and `state-change.ts` (classifier check) both landed correctly, but without execute.ts setting the field the classifier always sees `undefined` and falls through to legacy behavior.
Evidence
Spoonworks v0.53 validation run `xkyzfn64ao7w5yia4891my4p` (this morning):
```
By kind:
vulnerable_dependency_high: 4
missing_state_change: 1 ← still firing
```
Inspecting the cluster's postState:
```
mutWindowMs: 137 ← observer ran
domMutationCount: None ← field missing — execute.ts didn't set it
All postState keys: ['ariaSnapshot', 'consoleErrors', 'domErrorTextDetected',
'mutationObserverWindowMs', 'networkRequests', 'newPortalCount', 'title', 'url']
```
Fix
Re-applies the mutPayload extraction + childList mutation count + PostState assignment in execute.ts.
Expected impact
Next spoonworks run should drop the Remove-row cluster: 5 → 4 clusters, 4/4 = 100% precision.
🤖 Generated with Claude Code