fix(auth): treat "anonymous" as a built-in credential-less role#26
Open
cunninghambe wants to merge 1 commit into
Open
fix(auth): treat "anonymous" as a built-in credential-less role#26cunninghambe wants to merge 1 commit into
cunninghambe wants to merge 1 commit into
Conversation
RoleMutex.refresh() threw "Unknown role: anonymous" whenever a caller exercised a role not declared in surfacemcp.config.json roles[]. Since `surfacemcp init` writes roles:[] for a fresh project, any anonymous surface_call was rejected — breaking the entire unauthenticated surface for consumers like BugHunter (whose default no-login role is "anonymous"). doLogin() already handles a credential-less role (returns an unauthenticated session); the bug was purely the roles[] lookup throwing first. Synthesize the built-in "anonymous" role when it is not declared, so the public surface can always be exercised. A genuinely unknown, non-anonymous role still throws. Verified end-to-end: a BugHunter calibrate run against a bench Next.js app went from 12 "Unknown role: anonymous" infra failures to 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
RoleMutex.refresh()threwUnknown role: anonymousfor any role not declared insurfacemcp.config.jsonroles[]. Sincesurfacemcp initwritesroles: []for a fresh project, every anonymoussurface_callwas rejected — breaking the entire unauthenticated surface for consumers like BugHunter, whose default no-login role isanonymous.The design already intended to support this:
doLogin()returns an unauthenticated session for a credential-less role (andtypes.tsdocuments "A role without credentials is anonymous: requests go unauthenticated"). The bug was purely that theroles[]lookup at the top ofrefresh()threw before reaching that logic.What
Synthesize the built-in
anonymousrole when it isn't declared, so the public surface can always be exercised unauthenticated. A genuinely unknown, non-anonymous role still throws.Verified
role-mutex.test.ts, TDD): anonymous returns an unauthenticated session with emptyroles[]; caches; a real unknown role still throws; an explicitly-declared anonymous behaves identically. 4/4 green, typecheck clean.calibraterun against a bench Next.js app went from 12Unknown role: anonymousinfra failures → 0; the interactive/API surface now executes asanonymous.🤖 Generated with Claude Code