fix downloadPages func in listing 9-11#8
Open
devashishraj wants to merge 1 commit intocutajarj:mainfrom
Open
Conversation
Author
|
there seems to be some extra changes due to auto-formatting by Goland IDE . If it's inconvenient i can revert these formatting change(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in listing 9_11 : downloadPages was sending all response bodies back to first channel of Pages slice , so i just removed the loop so per call downloadPages sends back channel containing single response body , now each channel in Pages slice contain response body.