Add different metrics to compute KNN#63
Open
SSamDav wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I added the option to use different metrics when creating the KNN.
Basically, I add the
metricargument to thepreserve_neighborsfunction and propagated this argument to thesklearn.neighbors.NearestNeighborsandpynndescent.NNDescentmethods.Note: I assumed that the possible values of the metric argument are the same for the both methods, I checked the documentation, and it seems that this is true. However, probably we should have a little more documentation to guide the final user.
Moreover, I don't use the
pnor themetric_kwds/metric_paramsargument of both methods, but it seems that one could do some logic to allow the user to use these parameters.