fix: compare JSON nesting, list null array, hold-remove false success + 1.0.10 release prep#27
Merged
Merged
Conversation
- backup compare -o json double-nested its payload under .result.result.* — the ComparisonResult fields now inline at .result.* like every sibling command. - list on an empty deployment emitted "backups": null, breaking every consumer iterating .result.backups[]; it now emits []. - hold remove --yes printed "✓ Hold released" (exit 0) for holds that never existed — a false success on the legal-hold path: a typo'd backup ID confirmed a release while the real hold silently kept blocking retention. Removal of a nonexistent hold now fails with notfound.hold (exit 6) and points at `hold list`; the storage layer stays idempotent, the operator-facing verb validates. Release prep: CHANGELOG 1.0.10 (these three + the #26 sandbox pg_verifybackup -n fix already on main) and doc version examples bumped. All fixes carry regression tests; the test that encoded the old absent-hold exit-0 contract now asserts the new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three verified day-to-day inconveniences, each fixed with a regression test, plus the 1.0.10 release prep. (The #26
recovery drillsandbox fix is already on main and rides in this release.)backup compare -o jsondouble-nested its payload at.result.result.*— fields now inline at.result.*like every other command.listemitted"backups": null— now[], sojq '.result.backups[]'handles the empty case.hold remove --yesfalse success: releasing a nonexistent hold printed✓ Hold released(exit 0) while the real hold kept blocking retention. Nownotfound.hold(exit 6) with ahold listpointer; real releases unchanged. The old test encoding the exit-0 contract was rewritten.Verified: unit + full-tree suite green (
go vetclean); E2E against a live repo — fake-ID release refuses (6) and leaves the real hold untouched, real release still works; compare/list JSON shapes checked live.Also verified but deferred (backlog): YAML renderer prints big integers in e-notation;
-o csvnever produces the tabular shape its docs promise.