Refactoring sending/receiving#127
Closed
Sosthene00 wants to merge 19 commits into
Closed
Conversation
* new TypedSecretKey<State> type that keep track of changes made to a secret key and help enforce the protocol * NonEmptyNormalizedKeys type prevents empty keys array errors * taproot key normalization is now accessible as a public API, not buried inside a private function get_a_sum_secret_key * unrelated, but commited for convenience: calculate_partial_secret takes a secp context as argument
cygnet3
force-pushed
the
sending_typed_states
branch
from
510618f to
b718d49
Compare
cygnet3
force-pushed
the
sending_typed_states
branch
from
b718d49 to
ef551ed
Compare
Collaborator
Author
|
Superseded by #135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the sending and receiving low level logic around a few types that include a state to serve as foolproof for implementers.