Refactor/silentpayments transaction shared secret#141
Open
Sosthene00 wants to merge 6 commits into
Open
Conversation
P2SH-P2WPKH: validate the redeem-script hash160 against the output script pubkey before trusting it. Previously any push in script_sig was accepted without checking the commitment, which would silently allow malformed inputs to pass. P2TR: the old check for a script-path spend indexed the last witness item as [1..33] without verifying length, which panics on items shorter than 33 bytes. Tighten the guard to control_block.len() >= 33 and only check effective_stack >= 2 (key-path spends have a single witness item). Extract last_push (returns the last data push in a push-only script) and witness_compressed_pubkey (verifies compressed pubkey + hash160 match) as helpers, removing three near-identical match blocks. Also includes PublicTweakData::new signature change from the two-NonEmptyArray pattern to &TransactionInputs (companion to the TransactionInputs commit).
…roduce `PublicTweakData`
Sosthene00
force-pushed
the
refactor/silentpayments-transaction-shared-secret
branch
from
56397f2 to
98cf407
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SharedSecretwithTransactionSharedSecret, that carries both the ECDH point and recipient scan key.PublicTweakDatafor receiver-side shared secret derivation usingTransactionInputs.calculate_label_hash,calculate_shared_secret_hash) and addNormalizedSecretKeytype for taproot key normalization.PartialSecret/calculate_partial_secretsending API unchanged for now.