Add a 'metadata' field to the proto definition for a usage update#9
Conversation
slr71
left a comment
There was a problem hiding this comment.
The field itself looks good. I think that code needs to be generated before the changes can be checked in. You can find some instructions for doing that in the README.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Ah, yes, sorry. I did my best at that -- I ended up with a newer java protobuf version in the process, as well as a newer |
|
Ah, that makes sense. Sounds good. I can see if I can regenerate the code and see what happens. 🤞 |
|
Ah, I commented before I realized that you generated the code. I think we can merge it and deal with any fallout that occurs when we update downstream repos. 👍 |
|
Alright, let's see what I break 🔨 Thanks for the review! |
QMS itself doesn't use these protos I don't think (at least not from what I could see) but stuff calling into it will, like resource-usage-api. This should, hopefully, be the right change to match with cyverse/qms#67