Open
Conversation
klatys
approved these changes
Oct 16, 2016
| if (!$category) { | ||
| throw new NotFoundHttpException("Kategorie neexistuje"); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Ty ponechané whitespacy, pryč (zde a :30)
| } | ||
| } | ||
|
|
||
| /* public function renderShow($id, $page, $more = null, $order = null) { |
Member
There was a problem hiding this comment.
Zakomentovaný kód většinou necommitujeme, nebo píšeme proč je zakomentovaný. Za půl roku nebudeš vědět proč tu je :)
| } | ||
|
|
||
| $paginator = new PaginatorHelper; | ||
| $products = $this->getDoctrine()->getRepository(Product::class)->countByCategory($category); |
| $page = $request->query->get('page'); | ||
|
|
||
| $paginator = new PaginatorHelper; | ||
| $products = $this->getDoctrine()->getRepository(Product::class)->countAll(); |
| ], | ||
| 21 | ||
| $paginator->getLength(), | ||
| $paginator->getOffset() |
| @@ -0,0 +1,256 @@ | |||
| <?php | |||
Member
There was a problem hiding this comment.
Palec nahoru za použití knihovny odjinud 👍
vasekboch
reviewed
Oct 16, 2016
| ') | ||
| ->setParameter("lft", $category->getLeft()) | ||
| ->setParameter("rgt", $category->getRight()); | ||
| dump($query->getScalarResult()); |
Collaborator
There was a problem hiding this comment.
Zapomenutý debug výstup :)
vasekboch
reviewed
Oct 16, 2016
Collaborator
vasekboch
left a comment
vasekboch
left a comment
There was a problem hiding this comment.
Hej za mě úplně v pohodě řešení. Až na čistotu výstupu nemám výhrad. Možná to vypadá jako banalita, ale v tom kódu se po tobě musí vyznat další lidé. A proto je potřeba menší štábní kultura :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aleš