Open
Conversation
lukasvrany
commented
Oct 21, 2016
lukasvrany
commented
- více adres bych řesil novou entitou Address, která by měla vazbu na entitu User.
- proměné, které se patří k adrese, by se přesunuly do nové entity.
- na stránce profilu uživatele by byla nová možnost přídat adresu a při editaci by byl např. selectbox na výběr adresy, kterou chci editovat
added 4 commits
October 21, 2016 23:09
vasekboch
reviewed
Oct 23, 2016
Collaborator
vasekboch
left a comment
vasekboch
left a comment
There was a problem hiding this comment.
Super. Plus za refaktoring. Možná bych se zarazil nad pojmenováním UserModel. Obecně to není moc dobrý přístup. Povím o tom něco víc na přednášce.
Collaborator
|
Jasně možnost uložit Adresu k uživateli je OK, ale není to moc dobrý přístup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.