Skip to content

Ukol 4 - Lukáš Vraný#36

Open
lukasvrany wants to merge 4 commits intoczcodecamp:masterfrom
lukasvrany:ukol4b
Open

Ukol 4 - Lukáš Vraný#36
lukasvrany wants to merge 4 commits intoczcodecamp:masterfrom
lukasvrany:ukol4b

Conversation

@lukasvrany
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Member

@klatys klatys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pár drobností jinak OK


{% block body %}
{% if faqs is null or faqs is empty %}
<h2>Žádné zajímevé otázky a odpovědi</h2>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, že myslíš i na tyto případy

use Symfony\Component\Routing\RouterInterface;

/**
* * @Route(service="app.controller.contact_controller")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asi překlep

use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

/**
* * @Route(service="app.controller.faq_controller")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tady taky, možná to tak máš nastaveno...

{
return $this->faqRepository->findBy(
[], [
"question" => "asc"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tady je nějak rozházený indent... nevím jestli bych řadil zrovna podle odpovědi, ale nijak jsme to neřešili, takže ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants