Make midnight-2 darker for more contrast with foreground.#1
Open
duncanburke wants to merge 20 commits intod11wtq:masterfrom
Open
Make midnight-2 darker for more contrast with foreground.#1duncanburke wants to merge 20 commits intod11wtq:masterfrom
duncanburke wants to merge 20 commits intod11wtq:masterfrom
Conversation
Added support for exporting and importing palettes in GIMP format, and created macros to make defining faces easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that when midnight-2 was used as the background colour, text was nearly unreadable due to a lack of contrast. This was most glaring with incremental searches and highlighting of changed hunks in magit.
I've made midnight-2 a darker colour which, I think, strikes a good compromise with being distinctive yet readable.