🎨 Palette: Improve accessibility of collapsible UI components#296
Conversation
💡 What: - Added `aria-expanded` and `aria-controls` to the toggle button in the `CollapsibleSection` component (used heavily in the JS8Call ListeningPost). - Used React's `useId()` hook to dynamically generate a unique ID for the content block to properly associate with `aria-controls`. - Added missing keyboard focus states (`focus-visible:ring-1 focus-visible:ring-cyan-500 outline-none`) to the toggle button. - Added `aria-hidden="true"` to purely decorative SVG icons within the button. - Applied identical accessibility improvements to the "Manual Entry" toggle block in `KiwiNodeBrowser.tsx` (hardcoded ID since it is a single instance). 🎯 Why: Screen reader users navigating custom accordion or collapsible blocks were previously unaware of the section's expanded/collapsed state or which content it controlled because the buttons lacked the semantic ARIA hooks (`aria-expanded` and `aria-controls`). Additionally, keyboard-only users lacked a clear visual indicator of which section was currently focused. ♿ Accessibility: - Explicitly binds the toggle button to its content container via `aria-controls`. - Exposes state via `aria-expanded`. - Restores keyboard focus visibility. - Hides decorative Chevrons from screen readers to reduce noise. Co-authored-by: d3mocide <136547209+d3mocide@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎨 Palette: Improve accessibility of collapsible UI components
💡 What:
aria-expandedandaria-controlsto the toggle button in theCollapsibleSectioncomponent (used heavily in the JS8Call ListeningPost).useId()hook to dynamically generate a unique ID for the content block to properly associate witharia-controls.focus-visible:ring-1 focus-visible:ring-cyan-500 outline-none) to the toggle button.aria-hidden="true"to purely decorative SVG icons within the button.KiwiNodeBrowser.tsx(hardcoded ID since it is a single instance).🎯 Why:
Screen reader users navigating custom accordion or collapsible blocks were previously unaware of the section's expanded/collapsed state or which content it controlled because the buttons lacked the semantic ARIA hooks (
aria-expandedandaria-controls). Additionally, keyboard-only users lacked a clear visual indicator of which section was currently focused.♿ Accessibility:
aria-controls.aria-expanded.PR created automatically by Jules for task 14437336375247061650 started by @d3mocide