⚡ Bolt: [performance improvement] Defer allocations in orbital prediction#302
⚡ Bolt: [performance improvement] Defer allocations in orbital prediction#302d3mocide wants to merge 1 commit into
Conversation
Moves the point dictionary creation and string formatting inside the `if el >= min_elevation` check to avoid unnecessary operations for non-visible passes. Co-authored-by: d3mocide <136547209+d3mocide@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Moved the creation of the
pointdictionary and thestrftimecall inside theif el >= min_elevation:condition inbackend/api/routers/orbital.py.🎯 Why: In the orbital pass prediction loop, the code previously generated a dictionary and formatted a datetime string (
t.strftime("%Y-%m-%dT%H:%M:%SZ")) on every single 10-second tick. For LEO satellites, the satellite is below the horizon for the vast majority of these ticks. Doing expensive string formatting and memory allocation only to immediately discard the result creates a major performance bottleneck.📊 Impact: This avoids thousands of unnecessary string formatting operations and memory allocations per satellite query, leading to significantly faster API response times for pass predictions.
🔬 Measurement: Verify by running the backend orbital prediction tests and observing faster overall execution times for large time windows or multiple satellites.
PR created automatically by Jules for task 15395275894077027152 started by @d3mocide