Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix SSRF bypass via unvalidated HTTP redirects in proxy_stream#76

Merged
d3mocide merged 1 commit into
mainfrom
sentinel/fix-ssrf-redirect-11510504226126764344
May 22, 2026
Merged

πŸ›‘οΈ Sentinel: [HIGH] Fix SSRF bypass via unvalidated HTTP redirects in proxy_stream#76
d3mocide merged 1 commit into
mainfrom
sentinel/fix-ssrf-redirect-11510504226126764344

Conversation

@d3mocide
Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: The /radio/proxy/{stream_id} endpoint instantiated an httpx.AsyncClient with follow_redirects=True. Although the initial URL is checked with validate_safe_url, if an external malicious server returns an HTTP 302 redirect pointing to an internal IP (like 127.0.0.1 or 169.254.169.254), httpx automatically follows it without triggering another SSRF check, bypassing the security control.
🎯 Impact: An attacker could bypass SSRF protections and proxy requests to internal backend services by serving redirects.
πŸ”§ Fix: Added an event_hooks={'request': [_validate_request_url]} callback to the httpx.AsyncClient which intercepts and runs validate_safe_url on every outgoing request during the client's lifecycle, fully blocking redirects to internal IPs.
βœ… Verification: Ran python3 -m unittest discover backend/tests/ to verify tests pass and ran manual testing to confirm redirects to 127.0.0.1 are successfully blocked by httpx.


PR created automatically by Jules for task 11510504226126764344 started by @d3mocide

… proxy_stream

Co-authored-by: d3mocide <136547209+d3mocide@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@d3mocide d3mocide merged commit eaeb5f3 into main May 22, 2026
3 checks passed
@d3mocide d3mocide deleted the sentinel/fix-ssrf-redirect-11510504226126764344 branch May 22, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant