π‘οΈ Sentinel: [HIGH] Fix SSRF via Unvalidated Redirects in Pollers#82
π‘οΈ Sentinel: [HIGH] Fix SSRF via Unvalidated Redirects in Pollers#82d3mocide wants to merge 1 commit into
Conversation
Co-authored-by: d3mocide <136547209+d3mocide@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Several poller modules (
alerts.py,gtfs_rt.py,news.py,utilities.py,weather.py) were usinghttpx.AsyncClientwithfollow_redirects=Truewithout validating the URLs of subsequent redirects against SSRF. This could allow external attacker-controlled servers to redirect outbound polling requests to internal/private loopback IP addresses (like127.0.0.1or0.0.0.0).π― Impact: Attackers could probe internal services, access metadata endpoints, or exploit other internal systems.
π§ Fix: Created a new centralized
poller/security.pymodeled afterbackend/security.pythat provides SSRF URL filtering. Addedvalidate_request_urlhook to all instances ofhttpx.AsyncClientthat follow redirects in the poller modules. Also, updatedbackend/security.pyto correctly block the0.0.0.0(unspecified) IPv4 address, which resolves to localhost on Linux and wasn't covered byis_privateoris_loopback.β Verification: Ran unit tests on both the backend and poller directories and confirmed successful functionality.
PR created automatically by Jules for task 8570493135598417741 started by @d3mocide