Backport fix - Issue #662692 strange decimal precision error on floating numeric fields.#7
Open
amorsent wants to merge 1 commit into
Open
Backport fix - Issue #662692 strange decimal precision error on floating numeric fields.#7amorsent wants to merge 1 commit into
amorsent wants to merge 1 commit into
Conversation
…trange decimal precision error on floating numeric fields.
Author
|
Note: This is the commit that went into Views 7.x-3.x and is how it is to this day. I discovered a different fix went into Views in core: That issue is apparently solving a different issue, but also fixes this one. Instead of cutting and pasting the decimal component it is determining the precision and then rounding. This also avoids the trailing 0's issue.... I can roll an alternate pull request using that fix if you like - but presumably it should go into 7.x-3.x first? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #662692 by joachim, hanoii, ShaneOnABike, lunazoid, 5t4rdu5t: strange decimal precision error on floating numeric fields.
Cherry-picked: https://git.drupalcode.org/project/views/commit/8d86ce2
Essentially in views_handler_field_numeric, if you don't set precision you can get weird floating point issues.