fix GetColumnNames() undefined behavior on empty label row#214
Merged
d99kris merged 1 commit intod99kris:dev/integrate-getcolumnnames-empty-label-rowfrom Apr 12, 2026
Conversation
GetColumnNames() did .begin() + (mRowNameIdx + 1) on the label row without checking that the row has enough elements. When the label row is empty (e.g. after InsertRow on an empty document with LabelParams(0,0)), .begin() wraps a null pointer and adding to it is undefined behavior. Add a bounds check before the iterator arithmetic so it returns an empty vector instead of hitting UB.
Owner
|
Thanks for contributing! Generally the patch looks good. I'll merge your fix into an integration branch and make some minor adjustments there. |
d99kris
changed the base branch from
master
to
dev/integrate-getcolumnnames-empty-label-row
d99kris
merged commit de6533b
into
d99kris:dev/integrate-getcolumnnames-empty-label-row
3 checks passed
Owner
|
This fix has been integrated to master in ab199f5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #213:
GetColumnNames() did .begin() + (mRowNameIdx + 1) on the label row without checking that the row has enough elements. When the label row is empty (e.g. after InsertRow on an empty document with LabelParams(0,0)), .begin() wraps a null pointer and adding to it is undefined behavior.
Add a bounds check before the iterator arithmetic so it returns an empty vector instead of hitting UB.