Added signout code for firebase, and a simple alert for public to sig…#9
Open
enayatullahna wants to merge 2 commits intodevelopfrom
Open
Added signout code for firebase, and a simple alert for public to sig…#9enayatullahna wants to merge 2 commits intodevelopfrom
enayatullahna wants to merge 2 commits intodevelopfrom
Conversation
jdkouris
reviewed
Jan 8, 2020
Comment on lines
+21
to
+25
| let alert = UIAlertController(title: "Sign up Alert!", message: "To view more or add dad jokes please sign up, under private tab.", preferredStyle: .alert) | ||
| alert.addAction(UIAlertAction(title: NSLocalizedString("OK", comment: "Default action"), style: .default, handler: { _ in | ||
| NSLog("The \"OK\" alert occured.") | ||
| })) | ||
| self.present(alert, animated: true, completion: nil) |
Contributor
There was a problem hiding this comment.
Hey @enayatullahna why are you adding the alert to the viewWillAppear? I thought we were going to add it as an alert when a user clicks on the cell?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n up.