Fix conditional registrations ignored when default has different reuse lifespan#697
Draft
Copilot wants to merge 4 commits into
Draft
Fix conditional registrations ignored when default has different reuse lifespan#697Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
…GHIssue #631) Agent-Logs-Url: https://github.com/dadhi/DryIoc/sessions/234b61f2-fffe-4a7a-9943-8098b4cd0293 Co-authored-by: dadhi <39516+dadhi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dadhi/DryIoc/sessions/234b61f2-fffe-4a7a-9943-8098b4cd0293 Co-authored-by: dadhi <39516+dadhi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dadhi/DryIoc/sessions/234b61f2-fffe-4a7a-9943-8098b4cd0293 Co-authored-by: dadhi <39516+dadhi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues with conditional registrations
Fix conditional registrations ignored when default has different reuse lifespan
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a conditional service (
Setup.With(condition: ...)) and an unconditional fallback are registered for the same interface with different reuse lifespans, the conditional registration is bypassed — the fallback is always resolved, even when the condition matches.Root Cause
In
GetServiceFactoryOrDefault, theImplicitCheckForReuseMatchingScopeblock callsFindFactoryWithTheMinReuseLifespanOrDefaultacross all condition-matched factories and returns early with the result. Since Singleton has a lower lifespan value than Transient, it was always winning — before the existing "prefer conditioned factories" logic (further down) had a chance to run.Fix
src/DryIoc/Container.cs: Within the reuse-matching early-return block, check whether exactly one of the reuse-matched factories carries an explicitSetup.Condition. If so, prefer it over the factory selected purely by minimum lifespan. UsingreuseMatchedFactories(not the broader set) ensures we don't promote a conditioned factory whose scope is incompatible with the current resolution context.test/DryIoc.IssuesTests/GHIssue631_Conditional_registrations.cs: EnabledTestWithDefaultScopedToSingletoninRun()— it was previously commented out as a known-failing case.