feat: collapse large summary file lists behind <details> block#372
Closed
drewbailey wants to merge 1 commit intodag-andersen:mainfrom
Closed
feat: collapse large summary file lists behind <details> block#372drewbailey wants to merge 1 commit intodag-andersen:mainfrom
drewbailey wants to merge 1 commit intodag-andersen:mainfrom
Conversation
When the total number of changed files exceeds --summary-threshold (default 20), the per-file listing is moved into a collapsible <details> block so the summary yaml block stays compact. Full list remains accessible on click. Also reminds users that context lines around diffs are already configurable via --line-count / -c (default 7).
Owner
|
Hi @drewbailey Sorry for the slow reply. I was busy finalizing As you may have noticed, this new version has made changes to the diff generation logic, which means you now have a lot of conflicts 😬 Would you mind updating the PR to match the new code? Also, when this is merged, I'll need to prepare a little integration test for it, so we can be sure it doesn't break in the future :) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the total number of changed files exceeds --summary-threshold (default 20), the per-file listing is moved into a collapsible
<details>block so the summary yaml block stays compact. Full list remains accessible on click.Also reminds users that context lines around diffs are already configurable via --line-count / -c (default 7)