Fix | Handle dual-purpose sources with both ref and path in repo-server-api renderer#402
Merged
dag-andersen merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #401
repo-server-apirenderer failed when a source had bothrefandpathset simultaneously (a valid Argo CD pattern for cross source references)splitSourcesnow treatsrefand content (path/chart) as independent concerns - a source with both ends up in both listsRoot Cause
splitSourcesclassified sources into mutually exclusive buckets: a source was either a ref source (ref != ""andpath == "") or a content source (everything else). A source with bothref: valuesandpath: manifestswas only placed incontentSources, so sibling chart sources couldn't resolve$values/...value files - producing:source referenced "$values", but no source has a 'ref' field defined
Fix
Replaced the three-way if/else with two independent checks:
Testing
TestBuildManifestRequest_ExternalChart_WithRefAndPath_GH401- reproduces the exact scenario from the issue