Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .dagger/migration-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Migration Report

## .dagger/modules/e2e requires explicit loading

The module at `.dagger/modules/e2e` is still valid, but it must be loaded explicitly.

- **This works**: `dagger -m .dagger/modules/e2e call --help`
- **This no longer works**: `cd .dagger/modules/e2e; dagger call --help`

ACTION: If your scripts rely on implicit loading of `.dagger/modules/e2e`, change them to use explicit loading.

## Root module requires explicit loading

The root module is still valid, but it must be loaded explicitly.

- **This works**: `dagger -m . call --help`
- **This no longer works**: `dagger call --help`

ACTION: If your scripts rely on implicit loading of the root module, change them to use explicit loading.
9 changes: 9 additions & 0 deletions .dagger/modules/e2e/dagger-module.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
name = "e2e"
engineVersion = "v0.20.6"

[runtime]
source = "dang"

[[dependencies]]
name = "go"
source = "../../.."
13 changes: 0 additions & 13 deletions .dagger/modules/e2e/dagger.json

This file was deleted.

10 changes: 10 additions & 0 deletions dagger.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Dagger workspace configuration
# Install modules with: dagger mod install <module>
# Example:
# dagger mod install github.com/dagger/dagger/modules/wolfi

[modules.dang-sdk]
source = "github.com/dagger/dang-sdk"

[modules.e2e]
source = ".dagger/modules/e2e"
8 changes: 4 additions & 4 deletions testdata/go-module-with-testdata/nesting_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func TestDaggerSessionAvailableFromGoTest(t *testing.T) {
directory(path: %q) { entries }
}
currentWorkspace {
path
cwd
directory(path: "/", include: ["LICENSE"]) { entries }
}
}`, wd),
Expand Down Expand Up @@ -70,7 +70,7 @@ func TestDaggerSessionAvailableFromGoTest(t *testing.T) {
} `json:"directory"`
} `json:"host"`
CurrentWorkspace struct {
Path string `json:"path"`
Cwd string `json:"cwd"`
Directory struct {
Entries []string `json:"entries"`
} `json:"directory"`
Expand All @@ -90,8 +90,8 @@ func TestDaggerSessionAvailableFromGoTest(t *testing.T) {
t.Fatalf("unexpected nested Dagger host directory entries: %v", entries)
}

if result.Data.CurrentWorkspace.Path != "testdata/go-module-with-testdata" {
t.Fatalf("unexpected nested Dagger workspace path: %q", result.Data.CurrentWorkspace.Path)
if result.Data.CurrentWorkspace.Cwd != "/testdata/go-module-with-testdata" {
t.Fatalf("unexpected nested Dagger workspace cwd: %q", result.Data.CurrentWorkspace.Cwd)
}
if !contains(result.Data.CurrentWorkspace.Directory.Entries, "LICENSE") {
t.Fatalf("unexpected nested Dagger workspace entries: %v", result.Data.CurrentWorkspace.Directory.Entries)
Expand Down