Skip to content

Fix file rename: pre-fill dialog and actually delete old file #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dail8859 merged 1 commit into from
May 2, 2026
Merged

Fix file rename: pre-fill dialog and actually delete old file #1038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ScintillaNext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ bool ScintillaNext::rename(const QString &newFilePath)
emit aboutToSave();

// Write out the buffer to the new path
if (saveCopyAs(newFilePath)) {
if (saveCopyAs(newFilePath) == QFileDevice::NoError) {
// Remove the old file
const QString oldPath = fileInfo.canonicalFilePath();
QFile::remove(oldPath);
Expand Down
2 changes: 1 addition & 1 deletion src/dialogs/MainWindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1479,7 +1479,7 @@ void MainWindow::renameFile()
if (editor->isFile()) {
const QString filter = app->getFileDialogFilter();
QString selectedFilter = app->getFileDialogFilterForLanguage(editor->languageName);
QString fileName = FileDialogHelpers::getSaveFileName(this, tr("Rename"), defaultDirectoryManager->getDefaultDirectory(), filter, &selectedFilter);
QString fileName = FileDialogHelpers::getSaveFileName(this, tr("Rename"), editor->getFilePath(), filter, &selectedFilter);

if (fileName.isEmpty()) {
return;
Expand Down