Skip to content

Force xcb platform on Wayland to fix tab drag indicators #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Force xcb platform on Wayland to fix tab drag indicators #1041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,25 @@ int main(int argc, char *argv[])
{
qSetMessagePattern("[%{time process}] %{if-debug}D%{endif}%{if-info}I%{endif}%{if-warning}W%{endif}%{if-critical}C%{endif}%{if-fatal}F%{endif}: %{message}");

#ifdef Q_OS_LINUX
// Qt Advanced Docking System positions its drop-indicator overlays as
// top-level Qt::Tool windows using mapToGlobal() + move() to absolute
// coordinates. Wayland does not let clients position top-level windows,
// so during a tab drag the indicators appear at wrong locations. Run
// through XWayland where the positioning works correctly. Honor an
// explicit QT_QPA_PLATFORM and an opt-out escape hatch.
if (qEnvironmentVariableIsEmpty("QT_QPA_PLATFORM")
&& !qEnvironmentVariableIsSet("NOTEPADNEXT_FORCE_NATIVE_WAYLAND"))
{
const QByteArray sessionType = qgetenv("XDG_SESSION_TYPE");
const bool isWayland = (sessionType == "wayland")
|| qEnvironmentVariableIsSet("WAYLAND_DISPLAY");
if (isWayland) {
qputenv("QT_QPA_PLATFORM", "xcb;wayland");
}
}
#endif

// Set these since other parts of the app references these
QApplication::setOrganizationName("NotepadNext");
QApplication::setApplicationName("NotepadNext");
Expand Down