fix profile popup while tabbing (bug #1949)#5145
Open
syu213 wants to merge 1 commit intodailydotdev:mainfrom
Open
fix profile popup while tabbing (bug #1949)#5145syu213 wants to merge 1 commit intodailydotdev:mainfrom
syu213 wants to merge 1 commit intodailydotdev:mainfrom
Conversation
syu213
requested review from
AmarTrebinjac,
capJavert,
omBratteng and
rebelchris
|
@syu213 is attempting to deploy a commit to the Daily Dev Team on Vercel. A member of the Team first needs to authorize it. |
Resolves accessibility issue where profile cards automatically opened popup tooltips when receiving keyboard focus, violating WCAG 2.1 guidelines. - Add trigger: 'mouseenter' to ProfileTooltip to prevent focus-triggered popups - Add keyboard navigation (Enter/Space) to open full profile pages - Add proper ARIA attributes for screen readers Fixes #1949
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
focus, complying with WCAG 2.1 guidelines
experience for mouse users)
profile cards
Events
Did you introduce any new tracking events?
No
Experiment
Did you introduce any new experiments?
No
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR