Skip to content

feat(bookmarks): add option to bookmark to a specific list#3547

Merged
idoshamun merged 1 commit intomainfrom
eng-603-add-option-to-bookmark-to-a-specific-list
Feb 5, 2026
Merged

feat(bookmarks): add option to bookmark to a specific list#3547
idoshamun merged 1 commit intomainfrom
eng-603-add-option-to-bookmark-to-a-specific-list

Conversation

@idoshamun
Copy link
Member

Summary

  • Added listId parameter to addBookmarks GraphQL mutation allowing Plus users to specify a target bookmark list directly
  • Added PATCH /public/v1/bookmarks/:id endpoint to move existing bookmarks to/from lists
  • Updated public API POST /public/v1/bookmarks to support listId parameter and return listId in response
  • Explicit listId overrides the "last used list" behavior; non-Plus users have the parameter ignored

Test plan

  • Integration tests for GraphQL mutation with explicit listId
  • Tests for invalid/unauthorized listId validation
  • Tests for non-Plus users (listId ignored)
  • Public API tests for creating bookmarks with listId
  • Public API tests for PATCH endpoint to move bookmarks

Closes ENG-603


Created by Huginn 🐦‍⬛

- Add optional listId parameter to addBookmarks GraphQL mutation
- Plus users can specify a target list when adding bookmarks
- Non-Plus users: listId parameter is silently ignored
- Plus user with invalid listId gets NOT_FOUND error
- Update POST /public/v1/bookmarks to accept listId
- Add PATCH /public/v1/bookmarks/:id endpoint to move bookmarks
- Response now includes listId for created bookmarks

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@pulumi
Copy link

pulumi bot commented Feb 5, 2026

🍹 The Update (preview) for dailydotdev/api/prod (at 868cda3) was successful.

Resource Changes

    Name                                                       Type                           Operation
~   vpc-native-sync-subscription-with-cio-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-temporal-deployment                             kubernetes:apps/v1:Deployment  update
~   vpc-native-user-posts-analytics-refresh-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-public-threshold-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-updated-sync-cron                  kubernetes:batch/v1:CronJob    update
+   vpc-native-api-clickhouse-migration-6fa78bbf               kubernetes:batch/v1:Job        create
~   vpc-native-hourly-notification-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-daily-digest-cron                               kubernetes:batch/v1:CronJob    update
~   vpc-native-update-views-cron                               kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-stale-user-transactions-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-update-highlighted-views-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-opportunities-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-private-deployment                              kubernetes:apps/v1:Deployment  update
-   vpc-native-api-clickhouse-migration-abbdec1e               kubernetes:batch/v1:Job        delete
~   vpc-native-generic-referral-reminder-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-clickhouse-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-calculate-top-readers-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-tag-view-cron                     kubernetes:batch/v1:CronJob    update
+   vpc-native-api-db-migration-6fa78bbf                       kubernetes:batch/v1:Job        create
~   vpc-native-check-analytics-report-cron                     kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-analytics-clickhouse-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-generate-search-invites-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-images-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-deployment                                      kubernetes:apps/v1:Deployment  update
~   vpc-native-update-trending-cron                            kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-validate-active-users-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-bg-deployment                                   kubernetes:apps/v1:Deployment  update
~   vpc-native-clean-zombie-user-companies-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-recommendations-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-ws-deployment                                   kubernetes:apps/v1:Deployment  update
-   vpc-native-api-db-migration-abbdec1e                       kubernetes:batch/v1:Job        delete
~   vpc-native-personalized-digest-deployment                  kubernetes:apps/v1:Deployment  update
~   vpc-native-update-tags-str-cron                            kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-users-cron                         kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-analytics-history-clickhouse-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-history-day-clickhouse-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-expire-super-agent-trial-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-gifted-plus-cron                          kubernetes:batch/v1:CronJob    update
... and 1 other changes

@idoshamun idoshamun merged commit 74fb9ee into main Feb 5, 2026
9 checks passed
@idoshamun idoshamun deleted the eng-603-add-option-to-bookmark-to-a-specific-list branch February 5, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant