Open
Conversation
added 4 commits
April 23, 2020 08:41
reginafernandezpinar
requested changes
Apr 23, 2020
Collaborator
reginafernandezpinar
left a comment
reginafernandezpinar
left a comment
There was a problem hiding this comment.
I think it would be better to make a new component Button so you can add the other kind of test that it is requested
added 2 commits
April 23, 2020 14:52
dailymp
requested changes
Apr 23, 2020
Owner
dailymp
left a comment
dailymp
left a comment
There was a problem hiding this comment.
Please review your pipeline is failing, and you have conflicts
added 5 commits
April 24, 2020 08:34
…t-testing-library-training into feature/issue#18-events-onClick
Collaborator
Author
|
Done! |
| <h1>Messages management sample, deployed</h1> | ||
| <MessageForm messages={messages} /> | ||
| <MessageList messages={messages} /> | ||
| <div> |
Collaborator
There was a problem hiding this comment.
I think you don´t need this div element here, your button component is enough. Have you tried without it?
| }); | ||
| it('should handle the click event', () =>{ | ||
| expect( | ||
| typeof component.find(Button).at(0).prop('onClickButton')).toBe('function'); |
Collaborator
There was a problem hiding this comment.
Another very useful test here is the one in which you call the function handled in the prop:
component.find(Button).prop('handleOnClick')();
expect(props.handleOnClick).toHaveBeenCalledTimes(1);
Collaborator
Author
There was a problem hiding this comment.
Done, I had forgotten to upload the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dailymp @mathewamg33 @reginafernandezpinar