Skip to content

fix: correct two regressions from code-review fixes #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daimpad merged 1 commit into from
Jun 4, 2026
Merged

fix: correct two regressions from code-review fixes #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,12 @@ async function saveMatch(match, playerEntries) {
console.error(err);
state.matches.pop();
recalculateStatsFromHistory();
// Revert any player ELOs already written to Supabase before the failure
try {
await Promise.all(playerEntries.map(({ id }) => updatePlayer(id, state.players[id])));
} catch (revertErr) {
console.error('ELO-Revert fehlgeschlagen:', revertErr);
}
showError('Fehler beim Speichern. Match wurde nicht übertragen.');
} finally {
toggleLoading(false);
Expand All @@ -343,13 +349,9 @@ async function removeMatch(id) {

recalculateStatsFromHistory();

// Only write back players who appeared in the deleted match
const affectedIds = match
? [...String(match.winnerId || '').split(','), ...String(match.loserId || '').split(',')]
.map(s => s.trim()).filter(s => s && state.players[s])
: Object.keys(state.players);

await Promise.all(affectedIds.map(pid => updatePlayer(pid, state.players[pid])));
await Promise.all(
Object.entries(state.players).map(([pid, player]) => updatePlayer(pid, player))
);

persistPlayers();
renderRankings(openProfileModal);
Expand Down
Loading