Delegate fail to fail_with_code (DSK-125)#166
Merged
Conversation
Unify error reporting so fail() reuses fail_with_code(report, 1) instead of duplicating eprintln and process::exit. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughsrc/report.rs内のfail関数が、eprintln!とprocess::exit(1)を直接実行する実装から、fail_with_code(report, 1)を呼び出す実装に変更されました。これにより失敗時の表示・終了処理はfail_with_code側に集約されます。公開されているシグネチャの変更はありません。 Changes変更内容(重大度: 低)
Sequence Diagram(s)sequenceDiagram
participant Caller
participant fail
participant fail_with_code
Caller->>fail: fail(report)
fail->>fail_with_code: fail_with_code(report, 1)
fail_with_code-->>Caller: process::exit(1)
関連する課題: なし 関連するPR: なし サジェストラベル: refactor, low-risk サジェストレビュアー: なし 詩
🚥 Pre-merge checks | ❌ 2❌ Failed checks (2 warnings)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fail()now delegates tofail_with_code(report, 1)instead of duplicatingeprintln!andprocess::exit.Test plan
cargo fmt --all --checkcargo auditcargo build --workspace --lockedcargo test -p rusternMade with Cursor
Summary by CodeRabbit