Deduplicate sample_ev test helper in forward.rs (DSK-133)#174
Merged
Conversation
Extract one module-level sample_ev() shared by four forward tests. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughcrates/rustern-core/src/runtime/forward.rs のテストモジュールにおいて、複数のテスト関数でローカルに重複定義されていた sample_ev() ヘルパー関数を共通の1箇所の定義に統合した。lossy モードの try_send 関連テスト、RunStats カウント検証テスト、source API エラー計測検証テストから重複するローカル定義を削除し、共通ヘルパーを参照するように変更した。forward_to_render のテストロジック自体(入力生成、チャネルサイズ、アサーション)に変更はない。公開APIの変更なし。 変更点
Possibly related issues
🚥 Pre-merge checks | ❌ 2❌ Failed checks (2 warnings)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sample_ev()helpers in forward tests to a single module-level function.Test plan
cargo test -p rustern-core --lib runtime::forwardMade with Cursor
Summary by CodeRabbit