Document level_classify Other allocation (DSK-138)#179
Merged
Conversation
Record why unknown level tokens keep an owned string for exit-watch matching; add regression test for non-standard level values. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
Changes
正しさ・非同期・K8s・セキュリティ観点: 本変更はドキュメントとテストのみで、ロジック変更なし。既存の Sequence Diagram(s)省略(ドキュメント/テストのみの変更のため、観測可能なフロー変化なし)。 Possibly related issues
🚥 Pre-merge checks | ❌ 2❌ Failed checks (2 warnings)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogLevel::Other(String)so--exit-watch-levelcan match arbitrary values downstream.notice).Test plan
cargo test -p rustern-core --lib pipeline::level_classifyMade with Cursor
Summary by CodeRabbit
levelの解釈ルールを明記し、標準外の値はそのまま保持されることを説明しました。level値でも元の文字列が保持されることを確認するテストを追加しました。