Fix wgrep footer marking excluding last result from edits#199
Open
fabianfranzelin wants to merge 1 commit into
Open
Fix wgrep footer marking excluding last result from edits#199fabianfranzelin wants to merge 1 commit into
fabianfranzelin wants to merge 1 commit into
Conversation
The previous code used (forward-line -1) after finding the 'rg finished' line, which moved point to the last result line and marked it as read-only footer. This caused wgrep to skip the last match during search-replace operations. Fix by using (beginning-of-line) on the 'rg finished' line itself, so only that line and anything after it is marked as footer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code used (forward-line -1) after finding the 'rg finished' line, which moved point to the last result line and marked it as read-only footer. This caused wgrep to skip the last match during search-replace operations.
Fix by using (beginning-of-line) on the 'rg finished' line itself, so only that line and anything after it is marked as footer.