Fix deprecation warnings from emacs31: if-let/when-let#200
Open
zenspider wants to merge 2 commits into
Open
Conversation
zenspider
force-pushed
the
zenspider__emacs31
branch
2 times, most recently
from
88ff4e0 to
d178867
Compare
Author
|
Tried to add emacs-31 to the CI but nix doesn't support that yet. All the other versions are happy with these changes. Also caught some doco references to emacs 26... bumped them to 28. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use this mode a lot and am driving emacs 31. Native compilation is on by default and I guess it won't write if there are warnings, so it is constantly popping up. This should address that.
I only byte compiled. I didn't run the tests locally because I don't use docker on this laptop. Hoping the GHA checks will address all that.