Implement bold-color support (bright and fixed)#253
Merged
Conversation
emil-e
reviewed
May 10, 2026
518367a to
30f8b8a
Compare
Collaborator
|
I'll have another look tomorrow! |
emil-e
requested changes
May 12, 2026
30f8b8a to
06b9347
Compare
emil-e
approved these changes
May 12, 2026
Collaborator
|
LGTM @dakra Any thoughts? I personally don't quite understand the point but given Ghostty proper has this, I'm guessing it's a thing that people want? :) |
Add support for Ghostty's `bold-color` configuration, allowing bold text to be rendered using bright colors or a specific fixed color. Summary of changes: - src/terminal.zig: Add `BoldConfig` and `bold_config` field to `Terminal`. - src/module.zig: Add `ghostel--set-bold-config` to update bold settings. - src/render.zig: Implement color substitution logic in `readCellProps`. Bold text with palette colors 0-7 is mapped to 8-15. Bold text with default foreground uses `bold_config.fixed_color` if mode is `fixed`. - lisp/ghostel.el: Add `ghostel-bold-color` defcustom (default `bright`) and logic to apply it to new and existing terminals. - test/ghostel-test.el: Add unit tests for both 'bright and fixed-color bold modes. - src/emacs.zig: Add `bright` symbol to cached symbols. Matches Ghostty 1.2.0 behavior. > Written by Gemini, tested by me.
22ebaaf to
0f65e93
Compare
Owner
lgtm. Thanks, merging.
Personally I'm also happy with just a bold face but I also don't have any aesthetic taste ;)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Ghostty's
bold-colorconfiguration, allowing bold text to be rendered using bright colors or a specific fixed color.Summary of changes:
BoldConfigandbold_configfield toTerminal.ghostel--set-bold-configto update bold settings.readCellProps. Bold text with palette colors 0-7 is mapped to 8-15. Bold text with default foreground usesbold_config.fixed_colorif mode isfixed.ghostel-bold-colordefcustom (defaultbright) and logic to apply it to new and existing terminals.brightsymbol to cached symbols.Matches Ghostty 1.2.0 behavior.