drop external_doc feature gate usage#85
Merged
isislovecruft merged 2 commits intodalek-cryptography:developfrom Jul 13, 2021
Merged
drop external_doc feature gate usage#85isislovecruft merged 2 commits intodalek-cryptography:developfrom
external_doc feature gate usage#85isislovecruft merged 2 commits intodalek-cryptography:developfrom
Conversation
daxpedda
reviewed
Jun 24, 2021
Contributor
|
I've stumbled on this when trying the |
Co-authored-by: daxpedda <daxpedda@gmail.com>
CjS77
added a commit
to tari-project/tari-crypto
that referenced
this pull request
Jul 2, 2021
Updated dependencies such that Rust stable 1.53 is now supported. The optimised avx_2 option will NOT rust on stable because there's still an unstable feature on subtle-ng. BUT this feature is actually for doc generation and has been removed from Rust. As soon as subtle-ng merges dalek-cryptography/subtle#85, avx2 will probably be supported on stable as well. The rand dep update breaks the benchmarks, but these will be fixed in the next commit.
CjS77
added a commit
to tari-project/tari-crypto
that referenced
this pull request
Jul 2, 2021
Updated dependencies such that Rust stable 1.53 is now supported. The optimised avx_2 option will NOT rust on stable because there's still an unstable feature on subtle-ng. BUT this feature is actually for doc generation and has been removed from Rust. As soon as subtle-ng merges dalek-cryptography/subtle#85, avx2 will probably be supported on stable as well. The rand dep update breaks the benchmarks, but these will be fixed in the next commit.
CjS77
added a commit
to tari-project/tari-crypto
that referenced
this pull request
Jul 2, 2021
Updated dependencies such that Rust stable 1.53 is now supported. The optimised avx_2 option will NOT rust on stable because there's still an unstable feature on subtle-ng. BUT this feature is actually for doc generation and has been removed from Rust. As soon as subtle-ng merges dalek-cryptography/subtle#85, avx2 will probably be supported on stable as well. The rand dep update breaks the benchmarks, but these will be fixed in the next commit.
CjS77
added a commit
to tari-project/tari-crypto
that referenced
this pull request
Jul 2, 2021
* Support stable rust Updated dependencies such that Rust stable 1.53 is now supported. The optimised avx_2 option will NOT rust on stable because there's still an unstable feature on subtle-ng. BUT this feature is actually for doc generation and has been removed from Rust. As soon as subtle-ng merges dalek-cryptography/subtle#85, avx2 will probably be supported on stable as well. The rand dep update breaks the benchmarks, but these will be fixed in the next commit. * Update benchmarks and fmt * Update benchmark code to use new dependency APIs * Run rust-fmt
CjS77
added a commit
to tari-project/tari-crypto
that referenced
this pull request
Jul 2, 2021
Updated dependencies such that Rust stable 1.53 is now supported. The optimised avx_2 option will NOT rust on stable because there's still an unstable feature on subtle-ng. BUT this feature is actually for doc generation and has been removed from Rust. As soon as subtle-ng merges dalek-cryptography/subtle#85, avx2 will probably be supported on stable as well. The rand dep update breaks the benchmarks, but these will be fixed in the next commit.
CjS77
added a commit
to tari-project/tari-crypto
that referenced
this pull request
Jul 5, 2021
* Support stable rust Updated dependencies such that Rust stable 1.53 is now supported. The optimised avx_2 option will NOT rust on stable because there's still an unstable feature on subtle-ng. BUT this feature is actually for doc generation and has been removed from Rust. As soon as subtle-ng merges dalek-cryptography/subtle#85, avx2 will probably be supported on stable as well. The rand dep update breaks the benchmarks, but these will be fixed in the next commit. * Update benchmarks and fmt * Update benchmark code to use new dependency APIs * Run rust-fmt * Use source coverage in tests Replace the grcov action with the more accurate source coverage approach as detailed in https://doc.rust-lang.org/nightly/unstable-book/compiler-flags/instrument-coverage.html This PR also provides the `test_coverage.sh` script that generates a test coverage report lcoally (see the comments for setting up pre-requisites) * Exclude std lib from coverage
2 tasks
Contributor
|
Note that has of now, the new |
isislovecruft
approved these changes
Jul 13, 2021
Member
isislovecruft
left a comment
isislovecruft
left a comment
There was a problem hiding this comment.
Hi @Centril! Thanks for the PR! Merging for 2.4.1.
Member
|
I suppose I should include this patch for releases of 2.3.x and 2.2.x since people seem to still be using those. |
Member
|
C.f. #86 where I describe and fix an issue, also note that currently I've only patched this to the 2.4.x series (but I'm perfectly happy to go back to other versions if anyone needs it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature no longer exists on nightly.