fix(keymaps): preserve default behavior in command-line buffer#3
Open
iamavolk wants to merge 2 commits intodaliusd:mainfrom
Open
fix(keymaps): preserve default behavior in command-line buffer#3iamavolk wants to merge 2 commits intodaliusd:mainfrom
iamavolk wants to merge 2 commits intodaliusd:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Preserve default key behavior when inside the command-line window (q:).
Why
Some people (myself, for instance) tend to use
<C-m>or<CR>for incremental selection. However, inside the cmd bufferone should be able to execute commands with the said keys. Hence the patch. Decrement got fixed along the way for consistency.
How
Added a
in_cmd_winhelper that checks buf type at keypress.Extra note
xmode doesn't seem to be affected or, at least, use cases are not well defined inside the said buffer type.