Skip to content

TransasctionEvent req w/o meterValues fails to be FormationViolation #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KSR-Yasuda wants to merge 1 commit into
base: main
Choose a base branch
from
Open

TransasctionEvent req w/o meterValues fails to be FormationViolation #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions OCPP.Core.Server/ControllerOCPP20.TransactionEvent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public string HandleTransactionEvent(OCPPMessage msgIn, OCPPMessage msgOut)
transaction.Uid = transactionEventRequest.TransactionInfo.TransactionId;
transaction.ChargePointId = ChargePointStatus?.Id;
transaction.ConnectorId = connectorId;
transaction.StartTagId = ct.TagId;
transaction.StartTagId = ct?.TagId;
transaction.StartTime = transactionEventRequest.Timestamp.UtcDateTime;
transaction.MeterStart = meterKWH;
transaction.StartResult = transactionEventRequest.TriggerReason.ToString();
Expand Down Expand Up @@ -328,7 +328,7 @@ private void GetMeterValues(ICollection<MeterValueType> meterValues, out double
meterTime = null;
stateOfCharge = -1;

foreach (MeterValueType meterValue in meterValues)
foreach (MeterValueType meterValue in meterValues ?? [])
{
foreach (SampledValueType sampleValue in meterValue.SampledValue)
{
Expand Down