This repository was archived by the owner on Apr 14, 2026. It is now read-only.
fix: auto-set DALCENTER_URL in daemon startup#706
Merged
Conversation
When DALCENTER_URL environment variable is empty, automatically set it
to http://localhost:{port} based on the daemon's listen address. This
ensures child processes and containers inherit the correct URL without
requiring manual configuration in /etc/dalcenter/*.env.
Closes #558
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run()초기화 시DALCENTER_URL환경변수가 비어있으면http://localhost:{addr}로 자동 설정/etc/dalcenter/*.env에 수동 설정 없이도 자식 프로세스/컨테이너가 올바른 URL을 상속Closes #558
Test plan
DALCENTER_URL미설정 상태로 데몬 시작 → 로그에DALCENTER_URL auto-set확인DALCENTER_URL사전 설정 상태로 데몬 시작 → 기존 값 유지 확인printenv DALCENTER_URL확인🤖 Generated with Claude Code