Add @public#2
Open
moble wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia 1.11's
publickeyword functions much the same asexport, so I think it makes sense to have the corresponding@publicmacro in this package.Here's the summary of things I've done:
@exportinto new methodhandle(::Expr,::Symbol).@publicNoExport.@publicinclude("NoExport.jl")to the top of the main file, which enables...@publicon older Julia versions.handle(::Val{:macrocall}, expr)to deal with expressions inside blocks with docstrings@publicin the README.Note that item 5 has the nice feature of letting us use
@public, even for code that will run on the old versions of Julia.