Open
Conversation
mdesmet
reviewed
Mar 2, 2023
trino/client.py
Outdated
| def _format_roles(self, roles): | ||
| def _format_roles(self, role, roles): | ||
| if role and roles: | ||
| raise ValueError("specify 'role' or 'roles' parameter, but not both") |
There was a problem hiding this comment.
Suggested change
| raise ValueError("specify 'role' or 'roles' parameter, but not both") | |
| raise ValueError("specify either 'role' or 'roles' parameter, but not both") |
trino/dbapi.py
Outdated
| transaction_id=NO_TRANSACTION, | ||
| extra_credential=extra_credential, | ||
| client_tags=client_tags, | ||
| role=role, |
There was a problem hiding this comment.
Move to last field to not break compatiblity
damian3031
force-pushed
the
add-role-parameter
branch
2 times, most recently
from
e8a6445 to
e886aba
Compare
damian3031
force-pushed
the
add-role-parameter
branch
from
e886aba to
1319a18
Compare
mdesmet
approved these changes
Apr 3, 2023
README.md
Outdated
| host='localhost', | ||
| port=443, | ||
| user='the-user', | ||
| roles="roleC" # equivalent to {"system": "roleC"} |
There was a problem hiding this comment.
I would avoid mixing uppercase and lowercase in the example.
damian3031
force-pushed
the
add-role-parameter
branch
from
1319a18 to
026e36f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: