Skip to content

Add swagger api file#2

Open
mishasdk wants to merge 3 commits into
masterfrom
bulumutka/add-swagger
Open

Add swagger api file#2
mishasdk wants to merge 3 commits into
masterfrom
bulumutka/add-swagger

Conversation

@mishasdk

Copy link
Copy Markdown
Collaborator

No description provided.

@mishasdk mishasdk requested a review from damoldavskiy March 27, 2021 13:39

@mishasdk mishasdk left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Еще, кажется будет лучше в некоторых местах рядом в user_email положить поле user_id, что бы не завязываться на email в запросах

Comment thread swagger.yaml
type: "string"
- in: "query"
name: "email"
name: "dialog_id"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Думаю, в dialog_history должен передаваться dialog_id, а не email конкретного пользователя. Тогда будет легче групповой чат сделать

Comment thread swagger.yaml
type: "string"
- in: "query"
name: "email"
name: "dialog_id"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут аналогично, сообщения должны посылаться в dialog

Comment thread swagger.yaml
example: "Hello, John!"
timestamp:
type: "integer"
example: 1616853526

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хотим иметь поле с временем отправки сообщения - добавил

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется в dialogs_info у нас дежит Message, а по логике должен лежать StorageMessage

Comment thread swagger.yaml
example: "Hello, John!"
timestamp:
type: "integer"
example: 1616853526

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StoredMessage - возвращаются в dialogs_history, для них тоже хотим знать время

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant