Skip to content

Upload .bidsignore files as part of BIDS datasets#1819

Merged
yarikoptic merged 1 commit intomasterfrom
bids-ignore
Mar 6, 2026
Merged

Upload .bidsignore files as part of BIDS datasets#1819
yarikoptic merged 1 commit intomasterfrom
bids-ignore

Conversation

@yarikoptic
Copy link
Member

Previously, find_dandi_files() skipped all dot-files including .bidsignore, so collaborators downloading a Dandiset would not receive this file. Now .bidsignore is allowed through the dot-file filter when inside a BIDS dataset, getting uploaded as a GenericBIDSAsset.

Previously, find_dandi_files() skipped all dot-files including .bidsignore,
so collaborators downloading a Dandiset would not receive this file.
Now .bidsignore is allowed through the dot-file filter when inside a BIDS
dataset, getting uploaded as a GenericBIDSAsset.

Fixes #1818

Co-Authored-By: Claude Code 2.1.63 / Claude Opus 4.6 <noreply@anthropic.com>
@yarikoptic yarikoptic added patch Increment the patch version when merged BIDS cmd-upload labels Mar 5, 2026
@CodyCBakerPhD
Copy link
Contributor

Tests LGTM

Surprised this hasn't been caught until now

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.12%. Comparing base (0fe497d) to head (6caea92).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
dandi/consts.py 0.00% 1 Missing ⚠️
dandi/files/__init__.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1819   +/-   ##
=======================================
  Coverage   75.11%   75.12%           
=======================================
  Files          84       84           
  Lines       11925    11930    +5     
=======================================
+ Hits         8958     8962    +4     
- Misses       2967     2968    +1     
Flag Coverage Δ
unittests 75.12% <77.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic
Copy link
Member Author

dev installs fiasco

INFO: pip is looking at multiple versions of pynwb to determine which version is compatible with other requirements. This could take a while.
ERROR: Cannot install hdmf 5.0.1.dev1+g0897b93b5 (from git+https://github.com/hdmf-dev/hdmf) and pynwb==3.1.4.dev9+g5980e7a87 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested hdmf 5.0.1.dev1+g0897b93b5 (from git+https://github.com/hdmf-dev/hdmf)
    pynwb 3.1.4.dev9+g5980e7a87 depends on hdmf<5 and >=4.1.2

Additionally, some packages in these conflicts have no matching distributions available for your environment:
    hdmf

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow p

is unrelated, let's proceed. Thanks @CodyCBakerPhD for the review

@yarikoptic yarikoptic merged commit 5f03d9b into master Mar 6, 2026
39 of 41 checks passed
@yarikoptic yarikoptic deleted the bids-ignore branch March 6, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BIDS cmd-upload patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically upload the .bidsignore file to the Dandiset

2 participants