Upload .bidsignore files as part of BIDS datasets#1819
Merged
yarikoptic merged 1 commit intomasterfrom Mar 6, 2026
Merged
Conversation
Previously, find_dandi_files() skipped all dot-files including .bidsignore, so collaborators downloading a Dandiset would not receive this file. Now .bidsignore is allowed through the dot-file filter when inside a BIDS dataset, getting uploaded as a GenericBIDSAsset. Fixes #1818 Co-Authored-By: Claude Code 2.1.63 / Claude Opus 4.6 <noreply@anthropic.com>
CodyCBakerPhD
approved these changes
Mar 5, 2026
Contributor
|
Tests LGTM Surprised this hasn't been caught until now |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1819 +/- ##
=======================================
Coverage 75.11% 75.12%
=======================================
Files 84 84
Lines 11925 11930 +5
=======================================
+ Hits 8958 8962 +4
- Misses 2967 2968 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
dev installs fiasco is unrelated, let's proceed. Thanks @CodyCBakerPhD for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, find_dandi_files() skipped all dot-files including .bidsignore, so collaborators downloading a Dandiset would not receive this file. Now .bidsignore is allowed through the dot-file filter when inside a BIDS dataset, getting uploaded as a GenericBIDSAsset.
.bidsignorefile to the Dandiset #1818 attn @kabilar