Count only for the first hit for subject or tissue within filename#173
Count only for the first hit for subject or tissue within filename#173yarikoptic wants to merge 2 commits intomasterfrom
Conversation
|
i think this also requires line 302 replaced with the sanitize function from dandi-cli. |
fecfb26 to
7b9a460
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
=======================================
Coverage 97.71% 97.72%
=======================================
Files 17 17
Lines 1751 1755 +4
=======================================
+ Hits 1711 1715 +4
Misses 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
did you try that and it resolved #172? would better be done in a separate PR then since this one does resolve issue too |
Also added assertion so we do not count incorrectly. But may be should be just a warning? Closes #172
7b9a460 to
ed02dec
Compare
I tested, it does. Will submit a complimentary PR. |
Also added assertion so we do not count incorrectly. But may be should be just a warning?
Closes #172