This repository was archived by the owner on Feb 18, 2024. It is now read-only.
Fix use with md-virtual-repeat (and other directives that recycle rep…#475
Open
jayellsbrg wants to merge 1 commit intodaniel-nagy:masterfrom
Open
Fix use with md-virtual-repeat (and other directives that recycle rep…#475jayellsbrg wants to merge 1 commit intodaniel-nagy:masterfrom
jayellsbrg wants to merge 1 commit intodaniel-nagy:masterfrom
Conversation
…eated items): update `self.id` before each access. - Also remove use of $parse. The model and items that are being accessed have already been parsed, but more importantly, md-virtual-repeat scrolling lagged/froze up when running the parse function every time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eated items): update
self.idbefore each access.Since
md-virtual-repeatrecycles elements, the model will update, but not create a new element, so postLink, and consequently, reassignment ofself.id, would not run again.$parse. The model and items that are being accessed have already been parsed, but more importantly,md-virtual-repeatscrolling lagged/froze up when running the parse function every time.