Skip to content

Support for MQTT#163

Open
danielbayerlein wants to merge 3 commits into
mainfrom
feat/next
Open

Support for MQTT#163
danielbayerlein wants to merge 3 commits into
mainfrom
feat/next

Conversation

@danielbayerlein

Copy link
Copy Markdown
Owner

No description provided.

@danielbayerlein danielbayerlein added the enhancement New feature or request label Mar 7, 2025
@danielbayerlein
danielbayerlein requested a review from Copilot March 7, 2025 14:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds support for MQTT publishing and updates the overall configuration, documentation, and CI pipelines to accommodate the new data sink.

  • Adds a new MQTT datasink using the paho-mqtt library.
  • Updates configuration functions, tests, and documentation to include MQTT settings.
  • Updates CI workflows, Python version requirements, and dependency versions.

Reviewed Changes

File Description
sepicker/datasinks/mqtt.py Introduces MQTT class for publishing data using paho-mqtt.
tests/test_can_bus.py Adds tests covering CAN bus functionality.
tests/test_config.py Updates tests for config reading including MQTT and MySQL.
.github/workflows/publish.yml Configures Docker related actions for publishing artifacts.
.github/workflows/ci.yml Updates CI workflow with new versions and Python 3.13.
README.md Updates documentation to reflect new MQTT and MySQL integrations.
sepicker/main.py Integrates both MySQL and MQTT datasinks in the main function.
sepicker/interface/can_bus.py Refactors type hints and logger naming for consistency.
Pipfile Updates dependencies and Python version to 3.13.
sepicker/config.py Adjusts configuration loading and environment variable processing.
sepicker/elster/elster_frame.py Adds type hints and minor cleanups to the ElsterFrame class.
sepicker/elster/elster.py Improves type hinting and logging in the Elster class.
sepicker/datasinks/mysql.py Updates type hints and logger naming in the MySQL datasink.

Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

sepicker/elster/elster.py:21

  • Avoid using 'type' as a variable name as it shadows the built-in Python function. Consider renaming it to 'msg_type'.
type = data[0] & 0x0f

Comment thread sepicker/config.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants