Support for MQTT#163
Open
danielbayerlein wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
PR Overview
This PR adds support for MQTT publishing and updates the overall configuration, documentation, and CI pipelines to accommodate the new data sink.
- Adds a new MQTT datasink using the paho-mqtt library.
- Updates configuration functions, tests, and documentation to include MQTT settings.
- Updates CI workflows, Python version requirements, and dependency versions.
Reviewed Changes
| File | Description |
|---|---|
| sepicker/datasinks/mqtt.py | Introduces MQTT class for publishing data using paho-mqtt. |
| tests/test_can_bus.py | Adds tests covering CAN bus functionality. |
| tests/test_config.py | Updates tests for config reading including MQTT and MySQL. |
| .github/workflows/publish.yml | Configures Docker related actions for publishing artifacts. |
| .github/workflows/ci.yml | Updates CI workflow with new versions and Python 3.13. |
| README.md | Updates documentation to reflect new MQTT and MySQL integrations. |
| sepicker/main.py | Integrates both MySQL and MQTT datasinks in the main function. |
| sepicker/interface/can_bus.py | Refactors type hints and logger naming for consistency. |
| Pipfile | Updates dependencies and Python version to 3.13. |
| sepicker/config.py | Adjusts configuration loading and environment variable processing. |
| sepicker/elster/elster_frame.py | Adds type hints and minor cleanups to the ElsterFrame class. |
| sepicker/elster/elster.py | Improves type hinting and logging in the Elster class. |
| sepicker/datasinks/mysql.py | Updates type hints and logger naming in the MySQL datasink. |
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
sepicker/elster/elster.py:21
- Avoid using 'type' as a variable name as it shadows the built-in Python function. Consider renaming it to 'msg_type'.
type = data[0] & 0x0f
danielbayerlein
force-pushed
the
feat/next
branch
from
March 7, 2025 14:24
5592e93 to
5b6d2f3
Compare
danielbayerlein
force-pushed
the
feat/next
branch
2 times, most recently
from
March 7, 2025 14:49
33f7c68 to
f005757
Compare
danielbayerlein
force-pushed
the
feat/next
branch
from
March 14, 2025 14:45
f005757 to
bb1d7ae
Compare
danielbayerlein
force-pushed
the
feat/next
branch
from
March 14, 2025 14:47
bb1d7ae to
03ea7a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.