Fixed crash in case if allowedFileTypes is not empty#30
Open
undersun81 wants to merge 2 commits intodanielbierwirth:masterfrom
Open
Fixed crash in case if allowedFileTypes is not empty#30undersun81 wants to merge 2 commits intodanielbierwirth:masterfrom
undersun81 wants to merge 2 commits intodanielbierwirth:masterfrom
Conversation
iceman201
reviewed
May 15, 2019
| if (self.allowedFileTypes.count == 0 || [self.allowedFileTypes containsObject:[file pathExtension]]) { | ||
| for (NSDictionary *file in files) { | ||
| BOOL isFolder = [file[ODBFileKeys.kDropboxFileType] isEqualToString: ODBFileKeys.kDropboxFileTypeFolder]; | ||
| NSString* fileExtension = [file[ODBFileKeys.kDropboxFileName] pathExtension]; |
There was a problem hiding this comment.
I think only
for (NSDictionary *file in files) {
if (self.allowedFileTypes.count == 0 || [self.allowedFileTypes containsObject:[file valueForKey:@"type"]]) {
[self.currentFiles addObject:file];
}
}
would work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for (NSString *file in files) {
'file' Expected type NSString but actual NSDictionary which leads to crash