Normalization#20
Conversation
- WebScan - NormalizedFeatures 2) settings.json stores the weights, api settings and the threshold. 3) minimum version of the Windows PowerShell was lowered to 1.8.3
|
These changes were implemented by Dmitrii as part of work to improve the accuracy of Revoke-Obfuscation on modules submitted to the PowerShell Gallery. We'd like to contribute them upstream. @LeeHolmes |
| @@ -160,6 +168,14 @@ http://www.leeholmes.com/blog/ | |||
| [Switch] | |||
| $CommandLine, | |||
|
|
|||
| [Parameter(Mandatory = $false)] | |||
| [Switch] | |||
| $NormalizedFeatures, | |||
There was a problem hiding this comment.
We probably want to tidy up the interface a bit. The names of the parameters are not very obvious, and it's possible to specify both -NormalizedFeatures and -WebScan, which I don't think makes sense. How about an optional -Model parameter, which can take enum values Standard, Normalized, or AzureML? Default would be Standard
There was a problem hiding this comment.
Yes, it is possible to specify both -NormalizedFeatures and -WebScan, but it will only run WebScan anyway.
I changed the names of the parameters to 'Normalized' and 'AzureML', but this interface is used in some functions that I haven't even looked at before. I can work on it when I'm done with my other tasks.
| .PARAMETER WebScan | ||
|
|
||
| (Optional) Uses a deployed model. | ||
|
|
||
| .PARAMETER Deep |
There was a problem hiding this comment.
Not sure why some funcs have Deep as an option and others don't. Does it still make sense to keep this as an option? In which case maybe it's another value which can be passed to -Model. If it doesn't outperform the other models maybe just remove it
|
@danielbohannon can you give us an idea whether you'll be open to merging this kind of thing? |
Error handling for Invoke-WebRequest. Minor changes.
…eeded. Added more comments. Parameter names more obvious now. Extra explanation of normalized parameter.
Uh oh!
There was an error while loading. Please reload this page.