Make docking the board to the bottom an opt-in option#75
Merged
Conversation
Follow-up to #46, which always anchored the board to the bottom. The default is now the normal top-docked layout; a new "Dock to bottom" toggle in Options opts into sitting the board near the bottom, clear of the omnibox suggestions that drop over the top while searching. The auto top-margin moves from .page onto a .page--dock-bottom modifier applied only when the setting is on. Adds a dockToBottom setting (default false). The #46 e2e is rewritten to assert top by default and bottom once enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #46. That PR always anchored the board to the bottom (to clear the
omnibox suggestions). Per request, that's now opt-in: the default is the
normal top-docked layout, and a new Dock to bottom toggle in Options
moves it down for anyone who wants the omnibox clearance.
How it works
autotop-margin moves off.pageonto a.page--dock-bottommodifier,applied only when the setting is on.
dockToBottomsetting (default false), normalized on read like theothers.
Default (top) vs. opt-in (bottom)