Skip to content

Improve bUnit test reliability #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Improve bUnit test reliability #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb6a650
Stabilize bUnit waits in flaky tests
Copilot May 7, 2026
1c12e85
Remove custom bUnit wait timeout
Copilot May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions JournalApp.Tests/ManageCategoriesTests.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@

// Submit changes and confirm they have changed on the main list.
layout.Find(".category-dialog .submit-button").Click();
layout.Find($"#manage-category-{guid} > .manage-category-edit-button").TextContent.Should().Be("New name");
layout.WaitForAssertion(() =>
layout.Find($"#manage-category-{guid} > .manage-category-edit-button").TextContent.Should().Be("New name"));
}

[Fact]
Expand Down Expand Up @@ -175,7 +176,8 @@

// Submit changes and confirm there is a new category in the list.
layout.Find(".category-dialog .submit-button").Click();
layout.FindAll(".manage-category-edit-button").Count.Should().Be(initialCount + 1);
layout.WaitForAssertion(() => layout.HasComponent<EditCategoryDialog>().Should().BeFalse());
layout.WaitForAssertion(() => layout.FindAll(".manage-category-edit-button").Count.Should().Be(initialCount + 1));
}

[Fact]
Expand All @@ -200,7 +202,8 @@

// Submit changes and confirm there is a new category in the list.
layout.Find(".category-dialog .submit-button").Click();
layout.FindAll(".manage-category-edit-button").Count.Should().Be(initialCount + 1);
layout.WaitForAssertion(() => layout.HasComponent<EditCategoryDialog>().Should().BeFalse());
layout.WaitForAssertion(() => layout.FindAll(".manage-category-edit-button").Count.Should().Be(initialCount + 1));
}

[Fact]
Expand Down Expand Up @@ -251,7 +254,7 @@
for (int i = 6; i > 1; i--)
{
cut.Find($"#manage-category-{guid} > .manage-category-up-button").Click();
Category().Index.Should().Be(i - 1);
cut.WaitForAssertion(() => Category().Index.Should().Be(i - 1));
}

cut.Find($"#manage-category-{guid} > .manage-category-up-button").HasAttribute("disabled").Should().BeTrue();
Expand Down